Skip to content

Conversation

arimus
Copy link
Contributor

@arimus arimus commented Nov 27, 2024

This commit demonstrates use of Module Federation in node using a project that is using vanilla JS and one that is using TypeScript.

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2024

CLA assistant check
All committers have signed the CLA.

@arimus
Copy link
Contributor Author

arimus commented Nov 27, 2024

I fixed the dynamic-remotes-node-javascript to dynamic-remotes-node that was in the original pull request :P And fixed the email address associated for the CLA signing to match up

@ScriptedAlchemy ScriptedAlchemy merged commit d288f00 into module-federation:master Dec 4, 2024
5 of 6 checks passed
Copy link

github-actions bot commented Dec 4, 2024

Workflow status is failure ❌
Unfortunately test report wasn't generated, it can be if no workspaces changed. Please check the workflow run below.
Link to GitHub workflow: Github Workflow Link

@github-actions github-actions bot added the workflow-failure Workflow is failed label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workflow-failure Workflow is failed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants