Skip to content

docs: enhance dynamic-remotes example documentation and modernization guide #4360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 3, 2025
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 23 additions & 19 deletions .github/workflows/on-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -264,22 +264,23 @@ jobs:
npx cypress verify || true
fi

- name: Install Playwright for projects that need it
- name: Install Playwright browsers for projects that use it
run: |
if [ "${{ matrix.container }}" = "bi-directional" ]; then
echo "Setting up Playwright for bi-directional example..."
cd ${{ matrix.container }}

# Check if we need to install Playwright browsers
if [ ! -d "$HOME/.cache/ms-playwright" ] || [ -z "$(ls -A $HOME/.cache/ms-playwright 2>/dev/null)" ]; then
echo "Installing Playwright browsers and dependencies..."
npx playwright install --with-deps chromium
else
echo "Playwright browsers already cached, installing system dependencies only..."
npx playwright install-deps chromium
fi

cd ..
echo "Installing Playwright browsers for projects that use it..."

# Install Playwright package first if not already available
if ! command -v playwright &> /dev/null; then
echo "Installing Playwright package..."
npm install -g playwright@^1.54.2
fi

# Check if we need to install Playwright browsers
if [ ! -d "$HOME/.cache/ms-playwright" ] || [ -z "$(ls -A $HOME/.cache/ms-playwright 2>/dev/null)" ]; then
echo "Installing Playwright browsers and dependencies..."
npx playwright install --with-deps chromium
else
echo "Playwright browsers already cached, installing system dependencies only..."
npx playwright install-deps chromium
fi

- name: Run sample webpack e2e tests
Expand All @@ -298,11 +299,14 @@ jobs:
pnpm --filter "${{ matrix.container }}" e2e:ci
(lsof -i tcp:3000-3999 -i tcp:4000-4999 -i tcp:8080-8100 | awk 'NR!=1 {print $2}' | xargs -r kill) 2> /dev/null

- name: Create artifacts for Allure report
id: create-artifacts-allure-report
- name: Create artifacts for test reports
id: create-artifacts-test-reports
uses: actions/upload-artifact@v4
if: always()
with:
name: allure-results
path: 'cypress/results/allure-results'
name: test-results-${{ matrix.container }}
path: |
${{ matrix.container }}/cypress/results/allure-results
${{ matrix.container }}/playwright-report
${{ matrix.container }}/test-results
retention-days: 7
Loading
Loading