Skip to content

fix: repair react-storybook e2e flow #4390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2025
Merged

fix: repair react-storybook e2e flow #4390

merged 1 commit into from
Sep 20, 2025

Conversation

ScriptedAlchemy
Copy link
Member

Summary

  • load the module federation addon through Storybook's webpackFinal hook so the remote button is resolvable
  • align the CRA host/remote button copy with the Playwright assertions and stop Storybook from auto-launching a browser
  • add the missing CRA lint/webpack peer dependencies so the dev servers can start cleanly during tests

Testing

  • pnpm test:e2e

https://chatgpt.com/codex/tasks/task_e_68ce52f7d48883258b704f6f1d8f0564

@ScriptedAlchemy
Copy link
Member Author

@codex re run prom install to regenerate the lock files in the repo

@chatgpt-codex-connector ChatGPT Codex Connector
Copy link

Summary

  • Regenerated the workspace pnpm lockfile by rerunning pnpm install, updating dependency metadata to the latest tree representation. pnpm-lock.yamlL1-L36

Testing

  • ✅ pnpm install

View task →

@ScriptedAlchemy ScriptedAlchemy merged commit 4b83c8d into mass-conversion Sep 20, 2025
5 of 6 checks passed
@ScriptedAlchemy ScriptedAlchemy deleted the codex/fix-failing-tests-in-storybook-example branch September 20, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ScriptedAlchemy