Skip to content

fix: update federated css remotes to React 18 root API #4393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2025
Merged

fix: update federated css remotes to React 18 root API #4393

merged 1 commit into from
Sep 20, 2025

Conversation

ScriptedAlchemy
Copy link
Member

Summary

  • replace legacy ReactDOM.render usage in the federated-css remote bootstrap files with React 18's createRoot API
  • ensure the remote dev servers mount without legacy warnings while continuing to expose the same components

Testing

  • timeout 600 pnpm e2e
  • timeout 600 sh -c 'CI=1 pnpm e2e:ci'

https://chatgpt.com/codex/tasks/task_e_68ce9ebebba8832597a5a6ebf39bde87

@ScriptedAlchemy ScriptedAlchemy merged commit 958f4a1 into mass-conversion Sep 20, 2025
5 checks passed
@ScriptedAlchemy ScriptedAlchemy deleted the codex/fix-federated-css-mono-example branch September 20, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ScriptedAlchemy