chore: asyncStartup for pure webpack/rspack examples only #4412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completes the migration of all example projects to use Playwright for E2E testing, ensuring consistent testing infrastructure across the monorepo and leveraging Playwright's improved performance and debugging capabilities.
- Migrate final set of projects to Playwright (quasar, react-storybook, redux-reducer-injection, rspack-webpack-interop) - Update pnpm lockfiles after dependency changes
Change the path from index.mjs to dist/index.js to reflect the new build output location
…er, fix imports, build pretest)
* fix: stabilize federated-css e2e * merge: bring branch up to date with mass-conversion; regen lockfiles
- federated-css-mono: use Playwright fixtures; wait for federated button; longer wait - nextjs-ssr: exclude Cypress spec via testMatch to avoid duplicate @playwright/test load - vue3-demo/typescript-monorepo: remove runAll aggregators to prevent duplicate/recursive tests - typescript-project-references: swap cypress->playwright imports - rust-wasm: relax post-stop console log assertion (tolerate <=1) - typescript: run webServer with build+serve for CI stability
- nextjs-ssr: use local @playwright/test (drop shared fixtures), add helper openLocalhost - federated-css-react-ssr: switch to Playwright selectors/constants; wait for federated button
…in migrated projects - Remove *.cy.ts and cypress.env from nextjs-ssr and federated-css-react-ssr - Switch specs to playwright fixtures/constants/selectors - Inline TypeScript app test data; drop CommonTestData and cypress-e2e deps - Add playwright-e2e/types/cssAttr to replace Cypress cssAttr
- vue3-demo: make test titles unique per app to avoid duplicates - vue2-in-vue3: add BaseMethods.checkCounterFunctionality to match Cypress helper - federated-css-mono: serve exposes on 400x; wait for Next on 8081 - typescript-project-references: correct imports to ../../../playwright-e2e - typescript: start both servers reliably with bash wait - rust-wasm: relax pre-stop log assertion to tolerate stragglers - typescript-monorepo: adjust package.json assertion for pnpm workspace
Delete and regenerate all pnpm lockfiles to ensure they are in sync with package.json files after merging master. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…deration.config.ts The merged configs were simplified versions that relied on external module-federation.config.ts files which don't exist. Restore the master versions that have inline MF config. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Revert angular-universal-ssr to master (Angular uses @ngtools/webpack) - Revert react-storybook to master (CRA-based, not pure webpack) - Revert umd-federation/app1 to use webpack.container.ModuleFederationPlugin (universal-module-federation-plugin incompatible with @module-federation/enhanced) - Regenerate lockfiles The asyncStartup feature should only be applied to pure webpack/rspack examples, not to framework-specific examples like Angular, Modern.js, or CRA-based apps. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…tibility The umd-federation example uses universal-module-federation-plugin which is incompatible with @module-federation/enhanced asyncStartup feature. Restore the dynamic import pattern to fix "Shared module is not available for eager consumption" error. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…bility The [email protected] overrides cause SWC Wasm plugin version mismatch with Modern.js builder-rspack-provider. The swc_core version 50.2.3 in rspack-canary is incompatible with the SWC plugins used by Modern.js examples like bi-directional. Removed the overrides to allow stable rspack versions to be used. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Instead of global pnpm overrides for rspack-canary, add the canary version as a direct npm alias in each pure rspack example's package.json. This prevents rspack-canary from affecting Modern.js, rsbuild, and other framework-based examples that need their own rspack versions. Updated 75 pure rspack examples that use asyncStartup experiment. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Use `playwright install --with-deps` for unified browser+deps installation - Add retry logic (3 attempts with 10s delay) to handle apt lock contention - Simplify installation steps in both setup-matrix and run-e2e-test jobs 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Member
Author
|
@2heal1 i have updated the version now. |
2heal1
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the asyncStartup sweep changes for ModernJS + Rsbuild-based examples (including clo + react-manifest-example), keeping the asyncStartup changes only for pure webpack/rspack examples.
Follow-up: close PR #4411 once this replaces it.