Skip to content

fix: try to find shared package.json #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

fix: try to find shared package.json #216

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
39fe32c
fix: try to find shared package.json
Dec 7, 2024
d975fd3
fix: prefer use require
Dec 12, 2024
273cf70
fix: remove function removePathFromNpmPackage
Dec 13, 2024
fed459d
fix: remove leading and trailing slash
Dec 16, 2024
121dd52
fix: normalize shared with trailing slash
Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/utils/normalizeModuleFederationOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export type RemoteEntryType =
| 'system'
| string;

import { existsSync } from 'fs';
import * as path from 'pathe';
import { warn } from './logUtils';

Expand Down Expand Up @@ -117,6 +118,24 @@ function removePathFromNpmPackage(packageString: string): string {
return match ? match[0] : packageString;
}

function findPackageJson(moduleName: string) {
const mainFilePath = require.resolve(moduleName);

let currentDir = path.dirname(mainFilePath);
while (
path.parse(currentDir).base !== 'node_modules' &&
currentDir !== path.parse(currentDir).root
) {
const potentialPackageJsonPath = path.join(currentDir, 'package.json');
if (existsSync(potentialPackageJsonPath)) {
return require(potentialPackageJsonPath);
}
currentDir = path.dirname(currentDir);
}

throw new Error(`Unable to find package.json for the module "${moduleName}"`);
Copy link
Collaborator

@gioboa gioboa Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it @nicotu01 👍
A good error message is always valuable

}

function normalizeShareItem(
key: string,
shareItem:
Expand All @@ -132,7 +151,7 @@ function normalizeShareItem(
): ShareItem {
let version: string | undefined;
try {
version = require(path.join(removePathFromNpmPackage(key), 'package.json')).version;
version = findPackageJson(removePathFromNpmPackage(key)).version;
} catch (e) {
console.log(e);
}
Expand Down
Loading