Skip to content

Conversation

@Nsttt
Copy link
Contributor

@Nsttt Nsttt commented Jan 22, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 22, 2026 10:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a crash in the DTS build process by adding comprehensive error handling around normalization functions. The changes wrap potentially failing operations in try-catch blocks to prevent unhandled exceptions from crashing the build.

Changes:

  • Refactored logDtsError function to handle different types of DTS options more robustly
  • Added try-catch blocks around normalizeDtsOptions, normalizeConsumeTypesOptions, and normalizeGenerateTypesOptions calls
  • Added a test case to verify the plugin handles invalid DTS options gracefully

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/plugins/pluginDts.ts Added error handling try-catch blocks around normalization functions and updated logDtsError to handle different option types
src/plugins/tests/pluginDts.test.ts Added test to verify plugin doesn't crash with invalid DTS options

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@gioboa gioboa merged commit 37e7ae0 into module-federation:main Jan 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants