Skip to content

Conversation

@Nsttt
Copy link
Contributor

@Nsttt Nsttt commented Jan 27, 2026

Summary

  • align vite-vite example deps/config with Vite 7
  • drop external remotes + dts generation from example
  • remove duplicate vite7-vite example

Testing

  • pnpm install

Copilot AI review requested due to automatic review settings January 27, 2026 17:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates the vite7-vite example into the main vite-vite example by upgrading vite-vite to Vite 7 and simplifying its configuration. The duplicate vite7-vite example directory is removed to reduce maintenance overhead.

Changes:

  • Updated vite-vite example dependencies from Vite 6 to Vite 7 and @vitejs/plugin-react from v4 to v5
  • Disabled DTS generation in both vite-host and vite-remote configurations
  • Removed external remote references (mfapp01, remote2, remote3) from vite-host configuration and imports
  • Deleted the entire vite7-vite example directory and its entries from pnpm-lock.yaml

Reviewed changes

Copilot reviewed 32 out of 38 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pnpm-lock.yaml Updated dependency versions for vite-vite example projects (Vite 6→7, plugin-react 4→5) and removed vite7-vite importer entries
examples/vite7-vite/vite-remote/* Deleted all files from the duplicate vite-remote directory
examples/vite7-vite/vite-host/* Deleted all files from the duplicate vite-host directory
examples/vite-vite/vite-remote/vite.config.js Disabled DTS generation (changed from configuration object to false)
examples/vite-vite/vite-remote/package.json Updated Vite to ^7.1.7 and @vitejs/plugin-react to ^5.1.2
examples/vite-vite/vite-host/vite.config.js Removed external remote configurations (mfapp01, remote2, remote3) and disabled DTS generation
examples/vite-vite/vite-host/src/App.jsx Removed imports and JSX for external remotes, fixed style quote consistency
examples/vite-vite/vite-host/package.json Updated Vite to ^7.1.7 and @vitejs/plugin-react to ^5.1.2
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome 👏 @Nsttt

@gioboa gioboa merged commit 3bb2d71 into module-federation:main Jan 27, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants