Fix memory_limit calculation in modTransportPackage #16820
Merged
+3
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opengeek
changed the title
smg6511
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Re-implements the
_bytesmethod usingini_parse_quantityintroduced in PHP 8.2, providing a polyfill for use in PHP 8.1.Why is it needed?
A php warning occurs (and gets logged in MODX as an error) because the
_bytesfunction attempts to use the inimemory_limitvalue in a calculation without removing the modifier string (e.g., 128M *= 1024). This triggers the “A non-numeric value encountered” warning.How to test
Related issue(s)/PR(s)
Resolves #16504. Alternate solution for #16797 that supports all valid quantities that might appear in the ini
memory_limitvalue.