Upgrade CI database images: MySQL 5.6 → 8.0, PostgreSQL 9.6 → 16#277
Open
opengeek wants to merge 1 commit intomodxcms:3.xfrom
Open
Upgrade CI database images: MySQL 5.6 → 8.0, PostgreSQL 9.6 → 16#277opengeek wants to merge 1 commit intomodxcms:3.xfrom
opengeek wants to merge 1 commit intomodxcms:3.xfrom
Conversation
MySQL 5.6 (EOL 2021) is not a valid test target for xPDO 3.2's PHP 8.1 minimum — the combination does not exist in production, and the 5.6 CI job was masking real MySQL 8 regressions (modxcms#207, modxcms#190). PostgreSQL 9.6 (EOL 2021) receives the same treatment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
The CI matrix was testing against MySQL 5.6 and PostgreSQL 9.6, both of which reached EOL in 2021. Neither is a valid test target for xPDO 3.2's PHP 8.1 minimum — MySQL 5.6 + PHP 8.x is not a supported or tested configuration upstream.
More critically, the MySQL 5.6 CI job was actively masking real regressions:
createObjectContainer()PDOException) only surfaces on MySQL 8+ whereERRMODE_EXCEPTIONis the effective defaultONLY_FULL_GROUP_BY) triggers on MySQL 5.7+, not caught by a 5.6 jobUpgrading to MySQL 8.0 and PostgreSQL 16 makes the CI suite honest about the environments xPDO 3.2 is actually targeting.
Files and methods changed
.github/workflows/ci.yml—mysqlservice image:mysql:5.6→mysql:8.0.github/workflows/ci.yml—postgresservice image:postgres:9.6→postgres:16Cross-driver impact
CI hardening only. No xPDO source code changed.
Test coverage
No new tests. Existing MySQL and PostgreSQL test suites now run against current-generation database images.
Breaking change assessment
No public API change. This is a CI infrastructure update. Consumers running their own test suites against MySQL 5.6 or PostgreSQL 9.6 are unaffected by this change.
AI Disclosure
This fix was developed using an AI-assisted workflow. AI agents (Claude) wrote the code, tests, and initial code review under the direction of the project maintainer (@opengeek), who reviewed the final diff, validated the approach, and takes responsibility for the submission.
Contributors
No external contributors associated.