Fix STORAGE_DOMAIN conflict and disable CDN by default for OSS

[wzy403]

Change Summary

1. Resolve STORAGE_DOMAIN configuration conflict

• Previously, STORAGE_DOMAIN was hardcoded in docker-compose.yml as https://${DOMAIN}/storage/ which is for local storage type.
• This caused conflicts when attempting to config STORAGE_DOMAIN via the .env-backend configuration.
• After this change, STORAGE_DOMAIN is no longer hardcoded and can be configured correctly based on STORAGE_TYPE.

2. Disable CDN by default for OSS mode

• When using OSS storage mode, CDN access is now disabled by default, and can be explicitly enabled and configured if required.

Summary by CodeRabbit

• Chores
  • Updated default storage domain configuration format to a simplified placeholder.
  • Changed default behavior to disable CDN-based authentication for object storage, requiring explicit opt-in for CDN usage.
  • Updated Docker Compose configuration to align with simplified storage setup.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Configuration updates affecting storage domain initialization and CDN-based URL authentication. The STORAGE_DOMAIN placeholder was simplified from a full URL pattern, and CDN usage default was toggled to disabled in both environment samples and container orchestration setup.

Changes

Cohort / File(s)	Summary
Configuration & Deployment Setup .env-backend.sample, docker-compose.yml	STORAGE_DOMAIN simplified from full URL (https://change_me.org/storage/) to plain placeholder (change_me); OSS_VIA_CDN default toggled from True to False; environment variable binding removed from moeflow-backend service in compose file

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• Update env template #16: Modifies the same STORAGE_DOMAIN configuration in .env-backend.sample and moeflow-backend docker-compose service, indicating related infrastructure-level changes.

Poem

🐰 The storage path once long and grand,
Now rests as simple as the sand,
CDN sleeps while configs flow,
Domain changes, placeholders glow! ✨

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately summarizes the two main changes: fixing the STORAGE_DOMAIN conflict by removing it from docker-compose, and disabling CDN by default for OSS storage.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

.env-backend.sample (1)

36-36: Consider a more format-representative placeholder.

The placeholder change_me is generic and doesn't reflect that a full URL is expected (as described in the comments above). While the comments do provide clear format guidance, users might benefit from a placeholder that better hints at the expected format, such as:

• For a neutral example: https://your-domain.com/storage/ or https://example.com
• Or keeping it generic but adding a comment reminder at the end of the line

However, since the comments are clear and this is a sample file, the current approach is workable.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da8a01b and 38fb287.

📒 Files selected for processing (2)

• .env-backend.sample
• docker-compose.yml

💤 Files with no reviewable changes (1)

• docker-compose.yml

🔇 Additional comments (2)

.env-backend.sample (2)

57-57: LGTM! Disabling CDN by default is appropriate.

Setting OSS_VIA_CDN=False as the default is the correct choice since CDN with URL authentication requires additional configuration (CDN keys). This makes CDN opt-in, preventing potential errors for users who haven't configured CDN.

---

36-36: STORAGE_DOMAIN configuration is properly implemented.

The migration from hardcoded docker-compose to .env-backend has been correctly completed:

• STORAGE_DOMAIN was properly removed from all docker-compose files
• The moeflow-backend service correctly loads from .env-backend via env_file
• The placeholder value in .env-backend.sample allows operators to configure storage domain per deployment