Skip to content

Comments

feat(stage-pocket): push notifications#1016

Draft
LemonNekoGH wants to merge 4 commits intomainfrom
lemonnekogh/pocket-push-notifications
Draft

feat(stage-pocket): push notifications#1016
LemonNekoGH wants to merge 4 commits intomainfrom
lemonnekogh/pocket-push-notifications

Conversation

@LemonNekoGH
Copy link
Member

@LemonNekoGH LemonNekoGH commented Feb 1, 2026

This PR depends on #1021 because a bug.

@LemonNekoGH LemonNekoGH self-assigned this Feb 1, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @LemonNekoGH, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature to enable push notifications within the stage-pocket application. The primary goal is to inform users about significant events, such as AI chat completions, even when the application is not actively in use. This enhances user engagement by providing timely updates without requiring the app to be in the foreground.

Highlights

  • Push Notification Feature: Introduced a new useNotificationPush composable to manage push notification permissions and sending.
  • Application Integration: Integrated the push notification logic into the main App.vue component, requesting permissions on mount and cleaning up on unmount.
  • AI Chat Completion Notifications: Implemented a mechanism to send push notifications for AI chat completions when the application is not in the foreground.
  • Permission Handling: Added robust permission checking and requesting for local notifications using Capacitor's LocalNotifications plugin.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name Link
🔭 Waiting for approval For maintainers, approve here

Hey, @nekomeowww, @sumimakito, @luoling8192, @LemonNekoGH, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces local push notifications for completed AI chat messages when the application is in the background. The core logic is encapsulated in a new useNotificationPush composable, which is then integrated into the main App.vue component. The implementation is clean and follows good practices for Vue composables. I've provided a suggestion in notification-push.ts to improve the robustness of notification ID generation.


await LocalNotifications.schedule({
notifications: [{
id: Math.floor(Math.random() * 1000000),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using Math.random() for generating notification IDs can potentially lead to collisions, although the chance is small. This could cause a notification to be overwritten if another one is scheduled with the same ID. Using a timestamp from Date.now() is a simple and more robust way to ensure uniqueness.

Suggested change
id: Math.floor(Math.random() * 1000000),
id: Date.now(),

@LemonNekoGH LemonNekoGH force-pushed the lemonnekogh/pocket-push-notifications branch 3 times, most recently from 7473aee to 78765a9 Compare February 4, 2026 08:52
@LemonNekoGH LemonNekoGH force-pushed the lemonnekogh/pocket-push-notifications branch from ec17577 to 23fb8c6 Compare February 6, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant