fix(security): prevent env disclosure in createSpawnEnv#1199
fix(security): prevent env disclosure in createSpawnEnv#1199JasonOA888 wants to merge 9 commits intomoeru-ai:mainfrom
Conversation
Security fix: createSpawnEnv no longer inherits all environment variables from the main process. Before: Copied ALL env vars (AWS keys, API tokens, etc.) After: Only passes explicitly configured env vars This prevents sensitive information disclosure to MCP servers. Fixes moeru-ai#1186
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a critical security fix by modifying the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a critical security vulnerability by preventing the leakage of environment variables from the main process to spawned MCP server processes. The change in createSpawnEnv is a significant security improvement. I have one minor suggestion to improve the code's conciseness, but the core logic of the fix is sound.
| if (!overrides) { | ||
| return baseEnv | ||
| return {} | ||
| } | ||
|
|
||
| return { | ||
| ...baseEnv, | ||
| ...overrides, | ||
| } | ||
| return { ...overrides } |
There was a problem hiding this comment.
While the current implementation is correct, it can be made more concise. You can use the nullish coalescing operator (??) to handle the undefined case for overrides and simplify the function body to a single line.
return { ...(overrides ?? {}) }Simplified as suggested by Gemini Code Assist review. Before: if-else with separate returns After: Single line using ?? operator
⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.
Hey, @nekomeowww, @sumimakito, @luoling8192, @LemonNekoGH, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏 |
2 participants
Fixes #1186
Security fix: createSpawnEnv no longer inherits ALL environment variables from main process.
Before: Copied ALL env vars (AWS keys, API tokens, secrets)
After: Only passes explicitly configured MCP server env vars
This prevents sensitive information disclosure to MCP servers.