fix(services): resolve lint issues

[hobostay]

Summary

Fix lint issues identified by the linter.

Changes

• app.js: Use Number.isNaN() instead of global isNaN()
• app.js: Prefix unused variable result with underscore
• scheduler.ts: Remove unused variable log

Details

• Number.isNaN() is the preferred way to check for NaN in modern JavaScript
• Unused variables are flagged by the linter and should be removed or prefixed with underscore

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing code quality and adherence to coding standards by resolving several linting issues across the codebase. The changes involve updating JavaScript NaN checks to use the more robust Number.isNaN(), marking intentionally unused variables, and removing truly unused variables, all contributing to a cleaner, more maintainable, and error-resistant codebase.

Highlights

• JavaScript NaN check: Updated app.js to use Number.isNaN() for more reliable NaN checks, aligning with modern JavaScript best practices.
• Unused variable handling: Modified app.js to prefix the unused result variable with an underscore (_result) to explicitly mark it as intentionally unused, satisfying linter rules.
• Code cleanup: Removed an unused log variable from scheduler.ts, improving code cleanliness and resolving a linter warning.

Changelog

• services/minecraft/src/debug/web/app.js
  • Replaced the global isNaN() function with Number.isNaN() for more precise NaN value detection.
  • Renamed the result variable to _result to indicate it is an unused variable, satisfying linter requirements.
• services/satori-bot/src/core/loop/scheduler.ts
  • Removed an unused log variable declaration, streamlining the code.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses several linting issues across two services. The changes include using the more specific Number.isNaN(), removing an unused variable, and renaming another to indicate it's unused. My review includes a suggestion to further improve the code's clarity by removing an unnecessary destructuring, which makes the intent clearer.

[github-actions]

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name	Link
🔭 Waiting for approval	For maintainers, approve here

Hey, @nekomeowww, @sumimakito, @luoling8192, @LemonNekoGH, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏