Skip to content

chore(ci): added Scoop bucket manifest#1262

Open
stablegenius49 wants to merge 1 commit intomoeru-ai:mainfrom
stablegenius49:pr-factory/issue-1210-scoop-manifest
Open

chore(ci): added Scoop bucket manifest#1262
stablegenius49 wants to merge 1 commit intomoeru-ai:mainfrom
stablegenius49:pr-factory/issue-1210-scoop-manifest

Conversation

@stablegenius49
Copy link

Summary

  • add a Scoop bucket manifest for the Windows desktop release
  • extract the packaged Electron app from the NSIS installer using the standard Scoop #/dl.7z pattern
  • document the Scoop install flow in the main README

Testing

  • python3 -m json.tool bucket/airi.json >/dev/null

Closes #1210

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the installation experience for Windows users by integrating AIRI with Scoop, a popular command-line installer. It introduces a new Scoop manifest and updates the documentation, making it easier for users to manage AIRI installations on their systems.

Highlights

  • Scoop Integration: Added a Scoop bucket manifest for the Windows desktop release of AIRI.
  • Documentation Update: Documented the Scoop installation flow within the main README file.
  • Installer Extraction: Implemented extraction of the packaged Electron app from the NSIS installer using the standard Scoop "#/dl.7z" pattern.
Changelog
  • README.md
    • Updated with new installation instructions for Windows users leveraging Scoop.
  • bucket/airi.json
    • New file created to define the AIRI application for Scoop, including its version, download URL, hash, and installation steps.
Activity
  • No human activity (comments, reviews, etc.) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a Scoop manifest for installing AIRI on Windows and updates the README with instructions. While this is a great addition for Windows users, the Scoop manifest (bucket/airi.json) contains two critical issues that will prevent both installation and automatic updates from working correctly. I've provided specific comments and code suggestions to fix the pre_install script and the autoupdate hash configuration.

Note: Security Review has been skipped due to the limited scope of the PR.

Comment on lines +14 to +15
"Expand-7zipArchive \"$dir\\`$PLUGINSDIR\\app-64.7z\" \"$dir\"",
"Remove-Item \"$dir\\`$*\", \"$dir\\Uninstall*\" -Force -Recurse"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pre_install script is incorrect due to the usage of extract_dir.

  1. When extract_dir is used, $dir already points to the contents of $PLUGINSDIR. The path in Expand-7zipArchive is therefore incorrect as it includes a redundant, literal \$PLUGINSDIR` segment.
  2. The Remove-Item command attempts to remove files like Uninstall* which are not present in $dir because extract_dir only copies the contents of $PLUGINSDIR.

A cleaner script should expand the inner archive and then remove it.

Suggested change
"Expand-7zipArchive \"$dir\\`$PLUGINSDIR\\app-64.7z\" \"$dir\"",
"Remove-Item \"$dir\\`$*\", \"$dir\\Uninstall*\" -Force -Recurse"
"Expand-7zipArchive \"$dir\\app-64.7z\" \"$dir\"",
"Remove-Item \"$dir\\app-64.7z\" -Force"

Comment on lines +30 to +33
"hash": {
"url": "$baseurl/latest.yml",
"regex": "sha512:\\s$base64"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The autoupdate configuration for hash is inconsistent. The manifest specifies a SHA256 hash, but the autoupdate block is configured to extract a SHA512 hash from latest.yml. This will cause hash mismatch errors when users run scoop update.

To ensure consistency, the autoupdate mechanism should also use SHA256. A robust way to handle this is to use a separate checksum file. This approach assumes a .sha256 file is published alongside each release asset (e.g., AIRI-0.9.0-alpha.12-windows-x64-setup.exe.sha256), which is a common practice.

    "hash": {
      "url": "$urlNoFrag.sha256"
    }

@nekomeowww nekomeowww changed the title Add a Scoop bucket manifest for AIRI chore(ci): added Scoop bucket manifest Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Scoop Support

1 participant