chore(ci): added Scoop bucket manifest#1262
chore(ci): added Scoop bucket manifest#1262stablegenius49 wants to merge 1 commit intomoeru-ai:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the installation experience for Windows users by integrating AIRI with Scoop, a popular command-line installer. It introduces a new Scoop manifest and updates the documentation, making it easier for users to manage AIRI installations on their systems. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a Scoop manifest for installing AIRI on Windows and updates the README with instructions. While this is a great addition for Windows users, the Scoop manifest (bucket/airi.json) contains two critical issues that will prevent both installation and automatic updates from working correctly. I've provided specific comments and code suggestions to fix the pre_install script and the autoupdate hash configuration.
Note: Security Review has been skipped due to the limited scope of the PR.
| "Expand-7zipArchive \"$dir\\`$PLUGINSDIR\\app-64.7z\" \"$dir\"", | ||
| "Remove-Item \"$dir\\`$*\", \"$dir\\Uninstall*\" -Force -Recurse" |
There was a problem hiding this comment.
The pre_install script is incorrect due to the usage of extract_dir.
- When
extract_diris used,$diralready points to the contents of$PLUGINSDIR. The path inExpand-7zipArchiveis therefore incorrect as it includes a redundant, literal\$PLUGINSDIR` segment. - The
Remove-Itemcommand attempts to remove files likeUninstall*which are not present in$dirbecauseextract_dironly copies the contents of$PLUGINSDIR.
A cleaner script should expand the inner archive and then remove it.
| "Expand-7zipArchive \"$dir\\`$PLUGINSDIR\\app-64.7z\" \"$dir\"", | |
| "Remove-Item \"$dir\\`$*\", \"$dir\\Uninstall*\" -Force -Recurse" | |
| "Expand-7zipArchive \"$dir\\app-64.7z\" \"$dir\"", | |
| "Remove-Item \"$dir\\app-64.7z\" -Force" |
| "hash": { | ||
| "url": "$baseurl/latest.yml", | ||
| "regex": "sha512:\\s$base64" | ||
| } |
There was a problem hiding this comment.
The autoupdate configuration for hash is inconsistent. The manifest specifies a SHA256 hash, but the autoupdate block is configured to extract a SHA512 hash from latest.yml. This will cause hash mismatch errors when users run scoop update.
To ensure consistency, the autoupdate mechanism should also use SHA256. A robust way to handle this is to use a separate checksum file. This approach assumes a .sha256 file is published alongside each release asset (e.g., AIRI-0.9.0-alpha.12-windows-x64-setup.exe.sha256), which is a common practice.
"hash": {
"url": "$urlNoFrag.sha256"
}
Summary
#/dl.7zpatternTesting
python3 -m json.tool bucket/airi.json >/dev/nullCloses #1210