Skip to content

fix(stage-tamagotchi): provide the missing core components to createCoreContext#1288

Merged
nekomeowww merged 2 commits intomainfrom
fix/tamagotchi-i18n-missing-components
Mar 11, 2026
Merged

fix(stage-tamagotchi): provide the missing core components to createCoreContext#1288
nekomeowww merged 2 commits intomainfrom
fix/tamagotchi-i18n-missing-components

Conversation

@sumimakito
Copy link
Member

Register the messageCompiler, messageResolver, and localeFallbacker. It could be due to @intlify/core being too minimalistic, so that we need to provide more core components imported from @intlify/core back to createCoreContext.

While vue-i18n registers them globally:

registerMessageCompiler(compile)
registerMessageResolver(resolveValue)
registerLocaleFallbacker(fallbackWithLocaleChain)

See: https://github.com/intlify/vue-i18n/blob/884060b63122ccca3088e4af283ef223a1e2bd29/packages/vue-i18n/src/runtime.ts#L15-L22

... but we will provide them to createCoreContext here for better scoping.

Screenshot 2026-03-12 at 0 28 38

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name Link
🔭 Waiting for approval For maintainers, approve here

Hey, @nekomeowww, @sumimakito, @luoling8192, @LemonNekoGH, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏

@nekomeowww nekomeowww merged commit 28109a8 into main Mar 11, 2026
9 checks passed
@nekomeowww nekomeowww deleted the fix/tamagotchi-i18n-missing-components branch March 11, 2026 15:34
@Garfield550 Garfield550 linked an issue Mar 11, 2026 that may be closed by this pull request
6 tasks
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in the stage-tamagotchi application's internationalization setup by providing essential core components to the createCoreContext function. This ensures that message compilation, resolution, and locale fallback mechanisms are correctly initialized and scoped, enhancing the robustness and clarity of the i18n implementation.

Highlights

  • Internationalization Core Components: Imported and registered the messageCompiler, messageResolver, and localeFallbacker from @intlify/core to ensure createCoreContext has all necessary components for i18n functionality.
  • Improved Scoping: Explicitly provided these core components to createCoreContext within the createI18n function, moving away from global registration for better modularity and scoping.
  • Spell Check Configuration: Updated the cspell configuration to include 'fallbacker' in the dictionary, preventing false positives related to the new i18n terminology.
Changelog
  • apps/stage-tamagotchi/src/main/libs/i18n/index.ts
    • Imported compile, fallbackWithLocaleChain, and resolveValue from @intlify/core.
    • Provided messageCompiler, messageResolver, and localeFallbacker to createCoreContext for explicit registration.
  • cspell.config.yaml
    • Added fallbacker to the spell check dictionary.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses a missing configuration issue in createCoreContext for the i18n library by providing the messageCompiler, messageResolver, and localeFallbacker. The fix is well-reasoned and the implementation is sound. The suggestion to improve code readability by making the explanatory comment more concise remains valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

alpha13更新后右键异常

2 participants