Skip to content

feat: hide main window before onboarding#449

Draft
typed-sigterm wants to merge 7 commits intomoeru-ai:mainfrom
typed-sigterm:refactor/rust-cleanup
Draft

feat: hide main window before onboarding#449
typed-sigterm wants to merge 7 commits intomoeru-ai:mainfrom
typed-sigterm:refactor/rust-cleanup

Conversation

@typed-sigterm
Copy link
Collaborator

@typed-sigterm typed-sigterm commented Aug 25, 2025 •
edited
Loading

fix #346

Also refactors the rust side implementation.

@netlify
Copy link

netlify bot commented Aug 25, 2025 •
edited
Loading

✅ Deploy Preview for airi-docs ready!

Name Link
🔨 Latest commit 6f660f9
🔍 Latest deploy log https://app.netlify.com/projects/airi-docs/deploys/68afeb78af48a800088ef682
😎 Deploy Preview https://deploy-preview-449--airi-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Aug 25, 2025 •
edited
Loading

✅ Deploy Preview for airi-vtuber ready!

Name Link
🔨 Latest commit 6f660f9
🔍 Latest deploy log https://app.netlify.com/projects/airi-vtuber/deploys/68afeb7868260600088ce5d2
😎 Deploy Preview https://deploy-preview-449--airi-vtuber.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@typed-sigterm

This comment was marked as resolved.

Sign in to view
@typed-sigterm typed-sigterm force-pushed the refactor/rust-cleanup branch from a7c1733 to 5237ee8 Compare August 26, 2025 04:01
@typed-sigterm typed-sigterm changed the title refactor: use declarative window configuration feat: hide main window before onboarding Aug 26, 2025
@typed-sigterm typed-sigterm marked this pull request as ready for review August 26, 2025 16:19
@typed-sigterm
Copy link
Collaborator Author

typed-sigterm commented Aug 26, 2025

Someone tells Neko there's a problem with the passthrogh.

I'm unable to understand the passthrough implementation at apps\stage-tamagotchi\src\pages\index.vue. Chat & settings icons aren't displayed when Alt+Shift+I + hovering, idk why

@nekomeowww
Copy link
Member

nekomeowww commented Aug 28, 2025

I'm unable to understand the passthrough implementation at apps\stage-tamagotchi\src\pages\index.vue. Chat & settings icons aren't displayed when Alt+Shift+I + hovering, idk why

I discovered that as well, the impl here might have issues, feel free to raise another issue for this. Try toggle it twice, it should appear.

nekomeowww
nekomeowww approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@nekomeowww nekomeowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, massive.

@nekomeowww
Copy link
Member

nekomeowww commented Aug 28, 2025

conflicts.

@typed-sigterm typed-sigterm marked this pull request as draft August 28, 2025 04:50
@typed-sigterm
Copy link
Collaborator Author

typed-sigterm commented Aug 28, 2025 •
edited
Loading

20250828-125629.mp4

The similar bug appeared on passthrough feature, which is fixed by https://github.com/moeru-ai/airi/pull/449/files#diff-3f7ee1faa56af6a84cdfdd4af79955bbe9defb238c85072803782db29467e033L241. Togglling twice doesn't work.

@skirkru
Copy link
Contributor

skirkru commented Aug 28, 2025

@typed-sigterm what I can see its inverted, maybe you can leave it first,

Anyway shortcut is always buggy to me, its prioritize to call to top windows first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nekomeowww nekomeowww nekomeowww approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: does not hide main window when onboaring

3 participants

@typed-sigterm @nekomeowww @skirkru