Closes issue #1310 : Adds Select All Conversations Feature#1652
Open
goforbg wants to merge 6 commits intomoezbhatti:masterfrom
Open
Closes issue #1310 : Adds Select All Conversations Feature#1652goforbg wants to merge 6 commits intomoezbhatti:masterfrom
goforbg wants to merge 6 commits intomoezbhatti:masterfrom
Conversation
Contributor
|
Is it possible to split the PR into individual commits, the checklist is the good way to split the commits. This will help in debugging any issues |
Author
|
Sure will do that. |
…at child adapter-level.
Author
|
@GeoZac Can you check now? Split it into separate commits. |
Author
|
is @moezbhatti the only maintainer? |
|
Will this also add option to multi select receivers from contact list ? |
Author
|
@cleanerspam nope, just adds an option to the menu. |
|
Please merge this request. We need this feature. |
|
Link to issue #1789 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows a "Select All" feature in the main menu bar to Mark all as read / Unread, Pin to Top, Block All and Archive All.
Hides "Select All" when the list is empty / when all items are already selected manually (or using the Select All button)
Added translations for all languages
Provided comments on why it's implemented at child adapter-level.
This is my first PR at this repo, first time working with MVP architecture, would love to contribute more after feedback 🎉