Create dirs 000 to prevent mounting accidents#35
Open
tsaavik wants to merge 1 commit intomogilefs:masterfrom
Open
Create dirs 000 to prevent mounting accidents#35tsaavik wants to merge 1 commit intomogilefs:masterfrom
tsaavik wants to merge 1 commit intomogilefs:masterfrom
Conversation
With the mountpoints set to 000 processes will not be able to write to an un-mounted mount point, in the event that a disk is not mounted. Without this mogile could start up with an unmounted disk and start writing to the mount point's directory, which in all likelihood is the system drive. If the system drive fills you could be in for a world of hurt. There is code later in the script to fix this, but it would affect existing directories which may (for one reason on another) be non-ideal to users. But there is no reason not to create NEW directories this way to protect the majority of use cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the mountpoints set to 000 processes will not be able to write to an un-mounted mount point, in the event that a disk is not mounted.
Without this mogile could start up with an unmounted disk and start writing to the mount point's directory, which in all likelihood is the system drive. If the system drive fills you could be in for a world of hurt.
There is (optional) code later in the script to fix this, but it would affect existing directories which may (for one reason on another) be non-ideal to users. But there is no reason not to create NEW directories this way to protect the majority of use cases.