fix: Replace old prototype-based "defaultProps" with JS default parameters#296
Open
AleTid5 wants to merge 4 commits intomohitk05:masterfrom
Open
fix: Replace old prototype-based "defaultProps" with JS default parameters#296AleTid5 wants to merge 4 commits intomohitk05:masterfrom
AleTid5 wants to merge 4 commits intomohitk05:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In the
index.tsxfile, theReactInstaStoriescomponent currently usesReactInstaStories.defaultPropsto define default props. This approach triggers aconsole.errorwarning, as it will be deprecated in future major releases. This PR addresses the issue by replacing the deprecated approach with JavaScript default parameters.Context
The existing code generates a
console.errorwarning due to the deprecated usage ofReactInstaStories.defaultProps. This warning will be removed in upcoming major releases. To ensure code maintainability and align with modern best practices, the code is updated in order to use JavaScript default parameters.Checklist
ReactInstaStories.defaultProps.Screenshots