Replace createVehicleCrew with fn_createCrew#30
Merged
Conversation
Adapted from main KP-Liberation PR. Only edits were to adjust the player custom.sqf file as we use our own array setup. As the original PR says, we'll need to add the new variables in presets (KPLIB_o_crewman, KPLIB_o_pilot, KPLIB_b_crewStatic). More info here: KillahPotatoes#963 Co-Authored-By: Filip Maciejewski <4293906+veteran29@users.noreply.github.com> Co-Authored-By: PiG13BR <170875982+pig13br@users.noreply.github.com>
carlmylo
added
scripts
doxus
reviewed
Nov 17, 2024
| // Placeholder types | ||
| switch (_side) do { | ||
| case KPLIB_side_enemy : { | ||
| _typeCrew = KPLIB_o_rifleman; |
Comment on lines
+39
to
+65
| /* | ||
| Save it for later changes | ||
| switch (_side) do { | ||
| case KPLIB_side_enemy : { | ||
| if (_vehicle isKindOf "Air") then { | ||
| _typeCrew = KPLIB_o_pilot; | ||
| } else { | ||
| if ((_vehicle isKindOf "Tank") || {_vehicle isKindOf "Wheeled_APC_F"}) then { | ||
| _typeCrew = KPLIB_o_crewman; | ||
| } else { | ||
| _typeCrew = KPLIB_o_rifleman; | ||
| } | ||
| } | ||
| }; | ||
| case KPLIB_side_player : { | ||
| if (_vehicle isKindOf "Air") then { | ||
| _typeCrew = KPLIB_b_heliPilotUnit; | ||
| } else { | ||
| if ((_vehicle isKindOf "Tank") || {_vehicle isKindOf "Wheeled_APC_F"}) then { | ||
| _typeCrew = KPLIB_b_crewUnit; | ||
| } else { | ||
| _typeCrew = KPLIB_b_crewStatic; | ||
| } | ||
| } | ||
| } | ||
| }; | ||
| */ |
There was a problem hiding this comment.
Is this supposed to be commented out?
If you want to add those new variables in presets, then yes. The original version uses them. I tested a lot and works just fine.
jishnukarri
added a commit
to phantom24201/KP-Liberation-APR
that referenced
this pull request
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapted from a v0.96.8 branch KP-Liberation PR.
Only edits were to adjust the player custom.sqf file as we use our own array setup. As the original PR says, we'll need to add the new variables into presets (KPLIB_o_crewman, KPLIB_o_pilot, KPLIB_b_crewStatic).
More info here: KillahPotatoes#963