You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@mojaie sorry for pinging you once more on this. I had the impression that you liked the idea of adding a cdxml reader?
If it's just lack of time, you might leave a short note.
I'm sorry for the late response.
It looks good to me. If there is any specific reason why you chose LightXML.jl instead of EzXML.jl, please let me know.
I’m ready to merge whenever you are.
LightXML was a pick from the AI, but as EzXML is meanwhile hosted by JuliaIO, it's probably the better choice, moreover we're using it in GenieFramework.
So I took some time to switch to EzXML and cleaned up the code a bit.
The only two functions to be exported are cdxmltomol and cdxmltomols. They have similar syntax as sdftomol. Morevover, there are CDXMLAtom, CDXMLBond and CDXMLMolGraph.
So I guess it's ready for merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a reader for cdxml format that supports