Draft
Conversation
* feat(3574): updated prepare handler for FX * feat(3574): added fxTransfer related tables; updated validator for FX * feat(3574): added fxTransfer related tables; updated validator for FX * feat(3574): comments/todos * feat(3574): added fx roleTypes; added content.context * feat(3574): added cyril; updated unit-tests
* chore: updated central service shared lib * feat: added some changes for fx flow * feat: added changes for position prepare handler * chore: refactor cyril functions * feat: position-commit working * feat: upgraded central shared * chore(snapshot): 17.4.0-snapshot.0 * chore(snapshot): 17.4.0-snapshot.1 * chore(snapshot): 17.4.0-snapshot.2
* feat: add FX quotes endpointType and kafka topics * chore: upgrade cs-shared * chore: fix audit
… into feat/fx-impl
* fix: cluster performance testing issues (#996) * test: fix disconnect errors (#998) * chore(release): 17.6.1 [skip ci] * chore: fix current tests * boolean * chore: add endpoints to test data * fix endpoint import * chore: improve validator coverage * chore: move prepare tests into file to match src structure --------- Co-authored-by: Kalin Krustev <kalin.krustev@gmail.com> Co-authored-by: mojaloopci <info@mojaloop.io>
* chore: more coverage * coverage
…ndling (#1035) * chore: add integration test for batch * unit * reenable * chore: comments * feat: added timeout handler implementation * test * cleanup function * test * remove * reorder * fix potential int test failures * fix tests * fix: queries * unit tests * unskip * fix potential int test failures * reorder * fix replace * unit tests * fix: int tests * fix: issues * fix: fx timeout * chore: update central services shared * fix: cicd * fix: deps * fix: lint * fix: unit tests * chore: added unit tests * chore: added unit tests * pull,audit,dep * update tests * update position query logic * rename * add comment * detail --------- Co-authored-by: Vijay <vijaya.guthi@infitx.com>
kalinkrustev
requested review from
elnyry-sam-k,
kleyow,
mdebarros and
vijayg10
as code owners
|
vijayg10
requested changes
Jun 18, 2024
Comment on lines
+310
to
+312
| const cyrilOutput = await this.cyril.processFxFulfilMessage(transfer.commitRequestId, payload) | ||
| if (!transfer.fxWatchListId) { | ||
| throw new Error(`Commit request ID ${transfer.commitRequestId} not found in watch list`) | ||
| } |
Contributor
There was a problem hiding this comment.
Can we still have a function in cyril 'processFxFulfilMessage' for this check? I mean. you can remove the call 'getAllDetailsByCommitRequestId' in that function, but I would recommend the queries (getItemInWatchListByCommitRequestId) on watchlist in the cyril functions instead of having a join in other place. Because the watchlist logic may change and I wouldn't suggest merging watchList in the places other than cyril. I know it's additional query but I hope it will not impact performance that much compared to left join.
| .leftJoin('fxTransferStateChange AS tsc', 'tsc.commitRequestId', 'fxTransfer.commitRequestId') | ||
| .leftJoin('transferState AS ts', 'ts.transferStateId', 'tsc.transferStateId') | ||
| .leftJoin('fxTransferFulfilment AS tf', 'tf.commitRequestId', 'fxTransfer.commitRequestId') | ||
| .leftJoin('fxWatchList AS wl', 'wl.commitRequestId', 'fxTransfer.commitRequestId') |
Contributor
There was a problem hiding this comment.
Please see my above comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.