feat: validate inbound JWS + update deps and Node.js 24.15.0#470
Open
feat: validate
inbound JWS + update deps and Node.js 24.15.0#470
Conversation
Node.js 24.15.0 Leverage @mojaloop/sdk-standard-components Jws.validator to verify fspiop-signature headers on inbound quotes/fxQuotes requests. Gated by jws.jwsValidate config (default false). Keys loaded from JWS_VERIFICATION_KEYS_DIRECTORY with hot-reload via fs.watch. Bad signatures return FSPIOP error 3105 / HTTP 400. Update Node.js to 24.15.0 (Docker 24.14.1-alpine3.23). Bump deps: central-services-shared 18.35.7, axios 1.15.1, knex 3.2.9, mysql2 3.22.1, sinon 21.1.2, ncu 21.0.2. Add protobufjs overrides (7.5.5/8.0.1), convict 6.2.5, lodash 4.18.1, yaml 2.8.3. 0 vulnerabilities. Add JWS unit tests for coverage. Ref: mojaloop/project#4439
gibaros
requested review from
bushjames,
elnyry-sam-k,
geka-evk,
kalinkrustev,
kleyow,
oderayi,
shashi165 and
vijayg10
as code owners
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JWS validation on quotes/fxQuotes
hot-reloaded via fs.watch
vulnerabilities
Ref: mojaloop/project#4439