Open
Conversation
Contributor
Author
|
Failed for ree and ruby 2.0.0, I'll see if I can determine why. |
Contributor
|
There is a spec order dependent failure that I fixed in #206 - looks similar to that |
Contributor
Author
|
Yeah, looks like a likely culprit -- thanks @fcheung. |
Contributor
Author
|
Going to rebase this off master, now that #206 has been merged. |
lukeasrodgers
force-pushed
the
ruby-2-simplecov
branch
from
d18a6b7 to
47a5ec2
Compare
Supports ruby 2, in addition to 1.9.3 and 1.8.7 Set ENV['COVERAGE'] from the :coverage task, for backwards compatibility, though preferred way to run this would just be `COVERAGE=true bundle exec rake test`.
lukeasrodgers
force-pushed
the
ruby-2-simplecov
branch
from
47a5ec2 to
5df70b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces rcov with simplecov, which supports ruby 2, as well as 1.9.3 and 1.8.7.
Tested with (bundle exec)
rake coverageon ruby 2.1.2 and 1.9.3.Set ENV['COVERAGE'] from the :coverage task, for backwards compatibility, though preferred way to run this would just be
COVERAGE=true bundle exec rake test.I wasn't able to get rcov running on master, so I couldn't compare the output of simplecov with the (old) rcov output, but the simplecov output seems reasonable.