Skip to content

Fix a Clippy waring#54

Merged
tatsuya6502 merged 2 commits intov0.11.xfrom
chore/fix-ci/v0.11.x/2026-03-01
Mar 1, 2026
Merged

Fix a Clippy waring#54
tatsuya6502 merged 2 commits intov0.11.xfrom
chore/fix-ci/v0.11.x/2026-03-01

Conversation

@tatsuya6502
Copy link
Member

@tatsuya6502 tatsuya6502 commented Mar 1, 2026

Summary by CodeRabbit

  • Chores

    • Updated copyright year to 2026 in Apache and MIT licenses.
  • Refactor

    • Enhanced code safety by replacing unsafe operations with safer, endianness-preserving byte conversion methods.

@coderabbitai
Copy link

coderabbitai bot commented Mar 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ecd8f3 and 64857f4.

📒 Files selected for processing (3)
  • LICENSE-APACHE
  • LICENSE-MIT
  • src/common/frequency_sketch.rs

📝 Walkthrough

Walkthrough

This PR updates copyright years in license files from 2020–2024 to 2020–2026 and replaces an unsafe transmute operation with a safe from_ne_bytes conversion in a test initialization.

Changes

Cohort / File(s) Summary
License Files
LICENSE-APACHE, LICENSE-MIT
Updated copyright year range to 2026.
Unsafe Code Removal
src/common/frequency_sketch.rs
Replaced unsafe transmute with safe from_ne_bytes for test-generated item initialization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 The years march on, we update with care,
From twenty-twenty-four to twenty-twenty-six fair!
Unsafe transmute found a safer home,
In from_ne_bytes it now will roam,
With whiskers twitching, safety shines so bright! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title contains a typo ('waring' instead of 'warning') and is vague about which Clippy warning is being fixed. Correct the typo to 'warning' and be more specific about which Clippy warning is being addressed, e.g., 'Fix unsafe transmute Clippy warning'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/fix-ci/v0.11.x/2026-03-01

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tatsuya6502 tatsuya6502 added this to the v0.11.0 milestone Mar 1, 2026
Copy link
Member Author

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging.

@tatsuya6502 tatsuya6502 merged commit a4305fa into v0.11.x Mar 1, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant