feat: make late fee optional + don't include logo placeholder and empty client in the PDF#31
Merged
henritoivar merged 3 commits intomokuappio:mainfrom Sep 27, 2025
Conversation
henritoivar
approved these changes
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #24, I also don't need the late fee field, so I usually set it to 0%. But that looks odd! There is no actual legal requirement for this, so it will now be printed only if it's populated. The same thing goes for the placeholder logo, which was included in the PDF. If no client was selected, there was still the client text too in the PDF, which might never happen in practice, but no harm in excluding it :)
PDF state prior to this PR:
Empty state setup sc:
PDF excludes all empty values now:
Populated are still working :)