fix: remove marvinjs dependency to fix failing build #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # To be able to push to dockerhub, this execpts the following | ||
| # To be able to push to dockerhub, this expects the following | ||
| # secrets to be set in the project: | ||
| # - NPM_TOKEN : NPM auth token for accessing private chemaxon NPM registry |
Collaborator
There was a problem hiding this comment.
thanks for taking care of this, @bodom0015
btw, you might want to remove @chemaxon:registry=https://hub.chemaxon.com/artifactory/api/npm/npm/ from .npmrc while you're at it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Build is currently failing with a 401 while attempting to fetch MarvinJS package - I suspect that our license has finally expired for this product, and it's time to remove it as a dependency here since it is not being utilized.
The build is not currently failing on
mainsince it hasn't rebuilt but I suspect that as soon as it tries to build it will failThis was found while creating a PR that did not change the Docker image at all, and yet the build failed #3
Fixes #4
Approach
How to Test
If you see a green checkmark on this PR, then it is safe to merge 🎉main, so we won't know if it's fixed until this is merged 😓 🙏