feat: enhance PointOfSaleDetails with additional fields and update documentation links#466
Closed
cervantes-x wants to merge 3 commits intomollie:masterfrom
Closed
Conversation
Contributor
cervantes-x
commented
Dec 8, 2025
cervantes-x
commented
- Added new fields: maskedNumber, cardFingerprint, feeRegion, and receipt to the PointOfSaleDetails interface.
- Updated existing documentation links to reflect the latest API references.
- Updated cardLabel to include 'Vpay' and 'Maestro' options.
…cumentation links - Added new fields: maskedNumber, cardFingerprint, feeRegion, and receipt to the PointOfSaleDetails interface. - Updated existing documentation links to reflect the latest API references. - Updated cardLabel to include 'Vpay' and 'Maestro' options.
- Introduced a new optional field `cardFunding` to the PointOfSaleDetails interface, indicating the card funding type (credit or debit) if known. - Updated documentation to reflect the new field and its possible values.
janpaepke
reviewed
Dec 22, 2025
Collaborator
janpaepke
left a comment
janpaepke
left a comment
There was a problem hiding this comment.
Thanks for this PR! The new fields align well with the current Mollie API docs.
One issue: cardReadMethod is missing the contactless value.
The docs list:
chip | magnetic-stripe | near-field-communication | contactless | moto
Should be:
cardReadMethod?: 'chip' | 'magnetic-stripe' | 'near-field-communication' | 'contactless' | 'moto';
janpaepke
added
the
API discrepancy
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the PointOfSaleDetails interface with additional payment information fields and updates all documentation links to reference the latest Mollie API documentation.
Key changes include:
- Added four new fields to capture more detailed payment information:
maskedNumber,cardFingerprint(relocated),feeRegion, andreceipt - Introduced a new
PointOfSaleReceiptinterface to provide detailed transaction receipt information - Updated
cardLabeltype to include 'Vpay' and 'Maestro' options
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Added 'contactless' as a valid option for the cardReadMethod field in the PointOfSaleReceipt interface.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.