feat: add missing payment links params#471
Merged
Conversation
- Add missing customerId field for recurring payment links - Update CreateParameters to include all new fields (lines, billingAddress, shippingAddress, sequenceType, customerId) - Fix webhookUrl JSDoc (was incorrectly copied from redirectUrl) - Fix billingAddress/shippingAddress JSDoc to match API docs - Update allowedMethods with 9 missing payment methods - Correct JSDoc URLs that had typos
janpaepke
added
the
API discrepancy
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds missing payment link parameters to align the SDK with the Mollie API documentation, including support for order lines, address details, recurring payments, and updated payment method options.
Changes:
- Added support for order lines, billing/shipping addresses, and recurring payment setup (
lines,billingAddress,shippingAddress,sequenceType,customerId) - Fixed JSDoc descriptions for
webhookUrlandallowedMethodsto match current API documentation - Updated
CreateParametersto include all newly added fields
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/data/paymentLinks/data.ts | Added new optional fields (lines, addresses, customer/sequence for recurring), fixed JSDoc for webhookUrl, updated allowedMethods documentation with complete list of payment methods |
| src/binders/paymentLinks/parameters.ts | Updated CreateParameters to make all new fields available as optional parameters, changed structure to use PickOptional for better type safety |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
edorivai
approved these changes
Jan 14, 2026
Collaborator
edorivai
left a comment
edorivai
left a comment
There was a problem hiding this comment.
LGTM, the one comment I had has been addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PaymentLinkData:lines,billingAddress,shippingAddress,sequenceType,customerIdCreateParametersto include all new fieldsCloses #434
Based on contribution from @RubenSmn in #470 (re-submitted from main repo per #387)
References