Skip to content

chore: update Node.js versions in CI workflows #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoeck merged 3 commits into from
May 31, 2025
Merged

chore: update Node.js versions in CI workflows #1874

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b3beaa
chore: update Node.js versions in CI workflows
DarkGL May 9, 2025
73ccfa8
chore: update Node versions list
DarkGL May 9, 2025
ee21815
Remove outdated Node versions
DarkGL May 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,11 @@ jobs:
max-parallel: 3
matrix:
node-version:
- 16.x
- 18.x
- 19.x
- 20.x
- 21.x
- 22.x
- 23.x
- 24.x

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,11 @@ jobs:
# - NODE_VERSIONS in app.tsx
# - NODE_VERSION_FOR_PREVIEW in main.ts
node-version:
- 16.x
- 18.x
- 19.x
- 20.x
- 21.x
- 22.x
- 23.x
- 24.x

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion docs/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import * as vegaLite from 'vega-lite';

// which results are attempted to load
// the first is selected automatically
const NODE_VERSIONS = [23, 22, 21, 20, 19, 18, 16];
const NODE_VERSIONS = [24, 23, 22, 21, 20, 19, 18, 16];
Copy link
Collaborator

@hoeck hoeck May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as with bun, non-benchmarked node versions (16, 18, 19) should not be shown in the app.


const BUN_VERSIONS = [1.2, 1.1];

Expand Down