Skip to content

Using descriptor_class from Django 3.0 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Using descriptor_class from Django 3.0 #42

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcc52a0
Using descriptor_class from Django 3.0
boomboomb Feb 6, 2020
48ff6ba
change the way of populating _field_tof
boomboomb Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions tof/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,8 @@ def add_translation_to_class(self, trans_mng=None):
trans_mng.contribute_to_class(cls, 'objects')
origin.contribute_to_class(cls, 'objects_origin')

cls._meta._field_tof = {
'by_id': {self.id: self},
'by_name': {self.name: self}
}
cls._meta._field_tof['by_id'].update({self.id: self})
Copy link
Author

@baobab-ai baobab-ai Feb 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mom1 The original pull request had an issue, now this should do the work, originally there was setattr with nested setdefault. It was quite hard to read and understand. Also, I hope that a good idea to add more tests for core functionality.

cls._meta._field_tof['by_name'].update({self.name: self})

field = getattr(cls, self.name).field
field_class = TranslatableCharField if isinstance(field, models.CharField) else TranslatableTextField
Expand Down