chore: add _Cache to the create cache response#200
Open
bruuuuuuuce wants to merge 2 commits intomainfrom
Open
Conversation
bruuuuuuuce
requested review from
cprice404,
mjindalmotiv8,
rishtigupta and
tylerburdsall
tylerburdsall
previously approved these changes
Aug 23, 2023
Comment on lines
-57
to
-59
| message _CreateCacheResponse { | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Can we just edit the message in-place here so that _CreateCacheResponse comes after _CreateCacheRequest and maintains order?
tylerburdsall
approved these changes
Aug 23, 2023
cprice404
approved these changes
Aug 24, 2023
rishtigupta
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After creating a cache, we have to re-call list caches to get the limits of the newly created cache. It would be useful to have that information returned with the cache after it was created, since we can't see default limits.