Conversation
anitarua
left a comment
anitarua
left a comment
There was a problem hiding this comment.
my IDE had some trouble finding the auth package too, but one of the suggested actions was to "go get" it and it seemed to work. just fyi in case your IDE also has the same issue
There was a problem hiding this comment.
looking good! couple of notes:
- make sure to set MOMENTO_ENDPOINT to alpha (
cell-alpha-dev.preprod.a.momentohq.com) in the github workflow files that run tests so that the envVarV2 methods succeed - we still want keep test coverage for v1 api keys, so will need to use
auth.NewEnvMomentoTokenProvider("V1_API_KEY")inmomento/test_helpers/shared_context.goand add the V1_API_KEY env var to the github workflow files - to provide coverage for v2 api keys, let's create a new suite of tests. Can probably just copy-paste over the happy path test cases from the various test files into a single new test file
README.md
Outdated
|
|
||
| Momento Cache is a fast, simple, pay-as-you-go caching solution without any of the operational overhead | ||
| required by traditional caching solutions. This repo contains the source code for the Momento client library for Go. | ||
| required by traditional caching solutions. This repo contains the source code for the Momento client library for Go. |
There was a problem hiding this comment.
did not expect changes to the readme, which is generated from a template file in ci/ci, make sure to revert changes here and instead change the template
anitarua
changed the title
examples/aws-lambda/lambda/main.go
Outdated
| } | ||
|
|
||
| credentialProvider, err := auth.NewStringMomentoTokenProvider(authToken) | ||
| endpoint := "https://api.cache.cell-4-us-west-2-1.prod.a.momentohq.com" |
There was a problem hiding this comment.
Should this be hardcoded in the example, and should it be declared in the const block at the top of the file? I'm not too familiar with Go idioms.
There was a problem hiding this comment.
I think it probably depends on one's use case. Idk if many users would really set more than one endpoint, and was easier in this update to make it hardcoded, but good call on making it a const instead
3 participants
No description provided.