Skip to content

Conversation

@anitarua
Copy link
Contributor

@anitarua anitarua commented Mar 5, 2025

We had received the warning:

This is a scheduled Ubuntu 20.04 brownout. Ubuntu 20.04 LTS runner will be removed on 2025-04-01. For more details, see actions/runner-images#11101

Michael previously found no easy way to install python 3.7 and 3.8 on Ubuntu 24.04, and once we confirm no customers are still using those versions, we plan to remove 3.7 and 3.8 from the test matrix.

This PR will also update the test matrix to include python 3.12 and 3.13

Edit: it seems adding 3.13 won't work. The package grpcio didn't support python 3.13 until v1.66.2 and attempting to upgrade grpcio to that version produces this message:

The current project's Python requirement (>=3.7,<4.0) is not compatible with some of the required packages Python requirement:
  - grpcio requires Python >=3.8, so it will not be satisfied for Python >=3.7,<3.8

Because momento depends on grpcio (1.66.2) which requires Python >=3.8, version solving failed.

And in CI, python 3.13 cannot install seem to install the version of grpcio currently used in the sdk.

@malandis
Copy link
Contributor

malandis commented Mar 6, 2025

Let's remove 3.13 from the test matrix for now. Can follow up on resolving the version conflict with grpcio later. 👍

@anitarua anitarua changed the title ci: remove testing python 3.7 and 3.8, add testing python 3.12 and 3.13 ci: remove testing python 3.7 and 3.8, add testing python 3.12 Mar 6, 2025
malandis added 3 commits March 7, 2025 15:58
Because grpcio 1.66.2 is the minimum version that supports python
3.13, we add a conditional dependency on that version.
Previously I mistakenly cut and paste this to the test deps section.
@malandis
Copy link
Contributor

malandis commented Mar 8, 2025

I added support for python 3.13 in 5ee1847. Once we merge this we can bump the examples version.

@anitarua anitarua marked this pull request as ready for review March 31, 2025 19:00
@anitarua anitarua requested review from a team and malandis March 31, 2025 19:00
Copy link
Contributor

@pgautier404 pgautier404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anitarua anitarua merged commit 7c47aab into main Mar 31, 2025
10 checks passed
@anitarua anitarua deleted the update-ci branch March 31, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants