-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add middleware #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add middleware #502
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| from typing import Union | ||
|
|
||
| from momento.config.middleware.aio import Middleware as AsyncMiddleware | ||
| from momento.config.middleware.models import ( | ||
| MiddlewareMessage, | ||
| MiddlewareRequestHandlerContext, | ||
| MiddlewareStatus, | ||
| ) | ||
| from momento.config.middleware.synchronous import Middleware as SyncMiddleware | ||
|
|
||
| Middleware = Union[SyncMiddleware, AsyncMiddleware] | ||
|
|
||
| __all__ = [ | ||
| "Middleware", | ||
| "MiddlewareMessage", | ||
| "MiddlewareStatus", | ||
| "MiddlewareRequestHandlerContext", | ||
| ] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| from momento.config.middleware.aio.middleware import Middleware, MiddlewareRequestHandler | ||
| from momento.config.middleware.aio.middleware_metadata import MiddlewareMetadata | ||
|
|
||
| __all__ = ["Middleware", "MiddlewareMetadata", "MiddlewareRequestHandler"] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import abc | ||
|
|
||
| from momento.config.middleware.aio.middleware_metadata import MiddlewareMetadata | ||
| from momento.config.middleware.models import MiddlewareMessage, MiddlewareRequestHandlerContext, MiddlewareStatus | ||
|
|
||
|
|
||
| class MiddlewareRequestHandler(abc.ABC): | ||
| @abc.abstractmethod | ||
| async def on_request_metadata(self, metadata: MiddlewareMetadata) -> MiddlewareMetadata: | ||
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| async def on_request_body(self, request: MiddlewareMessage) -> MiddlewareMessage: | ||
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| async def on_response_metadata(self, metadata: MiddlewareMetadata) -> MiddlewareMetadata: | ||
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| async def on_response_body(self, response: MiddlewareMessage) -> MiddlewareMessage: | ||
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| async def on_response_status(self, status: MiddlewareStatus) -> MiddlewareStatus: | ||
| pass | ||
|
|
||
|
|
||
| class Middleware(abc.ABC): | ||
| @abc.abstractmethod | ||
| async def on_new_request(self, context: MiddlewareRequestHandlerContext) -> MiddlewareRequestHandler: | ||
| pass | ||
|
|
||
| # noinspection PyMethodMayBeStatic | ||
| def close(self) -> None: | ||
| return None |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| from typing import Optional | ||
|
|
||
| from grpc.aio import Metadata | ||
|
|
||
|
|
||
| class MiddlewareMetadata: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider making this a dataclass. You'd have to lift |
||
| """Wrapper for gRPC metadata.""" | ||
|
|
||
| def __init__(self, metadata: Optional[Metadata]): | ||
| self.grpc_metadata = metadata | ||
|
|
||
| def get_grpc_metadata(self) -> Optional[Metadata]: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accessors like this are uncommon. Can make |
||
| """Get the underlying gRPC metadata.""" | ||
| return self.grpc_metadata | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| from typing import Dict | ||
|
|
||
| import grpc | ||
| from google.protobuf.message import Message | ||
|
|
||
| CONNECTION_ID_KEY = "connectionID" | ||
|
|
||
|
|
||
| class MiddlewareMessage: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Everything here could be a dataclass. The sole field of this one would be m = MiddlewareMessage(message="asdf")
m.message_length
m.constructor_name
m.message |
||
| """Wrapper for a gRPC protobuf message.""" | ||
|
|
||
| def __init__(self, message: Message): | ||
| self.grpc_message = message | ||
|
|
||
| def get_message_length(self) -> int: | ||
| """Get the length of the message in bytes.""" | ||
| return len(self.grpc_message.SerializeToString()) | ||
|
|
||
| def get_constructor_name(self) -> str: | ||
| """Get the class name of the message.""" | ||
| return str(self.grpc_message.__class__.__name__) | ||
|
|
||
| def get_message(self) -> Message: | ||
| """Get the underlying gRPC message.""" | ||
| return self.grpc_message | ||
|
|
||
|
|
||
| class MiddlewareStatus: | ||
| """Wrapper for gRPC status.""" | ||
|
|
||
| def __init__(self, status: grpc.StatusCode): | ||
| self.grpc_status = status | ||
|
|
||
| def get_code(self) -> grpc.StatusCode: | ||
| """Get the status code.""" | ||
| return self.grpc_status | ||
|
|
||
|
|
||
| class MiddlewareRequestHandlerContext: | ||
| """Context for middleware request handlers.""" | ||
|
|
||
| def __init__(self, context: Dict[str, str]): | ||
| self.context = context | ||
|
|
||
| def get_context(self) -> Dict[str, str]: | ||
| return self.context | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| from momento.config.middleware.synchronous.middleware import Middleware, MiddlewareRequestHandler | ||
| from momento.config.middleware.synchronous.middleware_metadata import MiddlewareMetadata | ||
|
|
||
| __all__ = ["Middleware", "MiddlewareMetadata", "MiddlewareRequestHandler"] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import abc | ||
|
|
||
| from momento.config.middleware.models import MiddlewareMessage, MiddlewareRequestHandlerContext, MiddlewareStatus | ||
| from momento.config.middleware.synchronous.middleware_metadata import MiddlewareMetadata | ||
|
|
||
|
|
||
| class MiddlewareRequestHandler(abc.ABC): | ||
| @abc.abstractmethod | ||
| def on_request_metadata(self, metadata: MiddlewareMetadata) -> MiddlewareMetadata: | ||
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| def on_request_body(self, request: MiddlewareMessage) -> MiddlewareMessage: | ||
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| def on_response_metadata(self, metadata: MiddlewareMetadata) -> MiddlewareMetadata: | ||
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| def on_response_body(self, response: MiddlewareMessage) -> MiddlewareMessage: | ||
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| def on_response_status(self, status: MiddlewareStatus) -> MiddlewareStatus: | ||
| pass | ||
|
|
||
|
|
||
| class Middleware(abc.ABC): | ||
| @abc.abstractmethod | ||
| def on_new_request(self, context: MiddlewareRequestHandlerContext) -> MiddlewareRequestHandler: | ||
| pass | ||
|
|
||
| # noinspection PyMethodMayBeStatic | ||
| def close(self) -> None: | ||
| return None |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| from typing import Optional | ||
|
|
||
| from grpc._typing import MetadataType | ||
|
|
||
|
|
||
| class MiddlewareMetadata: | ||
| """Wrapper for gRPC metadata.""" | ||
|
|
||
| def __init__(self, metadata: Optional[MetadataType]): | ||
| self.grpc_metadata = metadata | ||
|
|
||
| def get_grpc_metadata(self) -> Optional[MetadataType]: | ||
| """Get the underlying gRPC metadata.""" | ||
| return self.grpc_metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer
get_async_middlewaresto parallel the cache naming.