chore: remove configuration bases and make middleware more pythonic #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgautier404
previously approved these changes
Apr 15, 2025
Contributor
pgautier404
left a comment
pgautier404
left a comment
There was a problem hiding this comment.
This looks good to me as long as @malandis signs off.
nand4011
force-pushed
the
middleware-improvements
branch
from
22279d9 to
455ace2
Compare
Remove the configuration base classes. These aren't used by any of the code that takes a configuration, so users can't implement new configurations with them and pass them into clients. I'm removing them instead of making the clients use them because config base classes make it difficult to add new configuration options breaking potential user implementations. Make the middleware classes into data classes. The existing standard classes with getters isn't pythonic. Make with_middlewares replace the configuration's middleware instead of adding to it. This matches the behavior in the other SDKs.
nand4011
force-pushed
the
middleware-improvements
branch
from
455ace2 to
06b75c4
Compare
malandis
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the configuration base classes. These aren't used by any of the code that takes a configuration, so users can't implement new configurations with them and pass them into clients. I'm removing them instead of making the clients use them because config base classes make it difficult to add new configuration options breaking potential user implementations.
Make the middleware classes into data classes. The existing standard classes with getters isn't pythonic.