Merged
Conversation
* Allows the other commands (which already have a configured profile) to share credential/profile logic without affecting `configure`
kirmar
commented
Mar 10, 2026
Ref: a88448d Co-authored-by: Kenny <kenny@momentohq.com>
tylerburdsall
previously approved these changes
Mar 10, 2026
kvcache
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares for #352 and improves internal consistency:
creds,config, andcredential_provideronly in momento/src/main.rs (and configure_cli.rs, since it has a unique process for checking existing credentials / creating new ones)creds,config, andcredential_provideronly once for Cache commands, once for Function commands, once for Topic commandsCacheClient,FunctionClient, andTopicClientconsistent. (Cache commands share a client as Function/Topic commands do, and Function/Topic commands have a client initialization util as Cache commands do)How to Review
configureand a couple other commands to ensure I didn't miss anythingCacheCommand's indentation changes, see the w=1 Files Changed orgit diff main --ignore-space-change