add client stateful tracking, use ring timestamps#7
Merged
0xflashboy merged 4 commits intomainfrom Dec 11, 2025
Merged
Conversation
0xflashboy
requested review from
AustinGreen,
Camillebzd,
Im-Madhur-Gupta,
iamvukasin,
marcuspang,
mijovic and
nkrishang
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
iamvukasin
reviewed
Dec 11, 2025
| if !seen_block_starts.insert(block_number) { | ||
| warn!("Duplicate BlockStart event for block {}", block_number); | ||
| } | ||
| match event.event_name { |
Contributor
There was a problem hiding this comment.
Do we still need it? Was it just used for debugging?
Collaborator
Author
There was a problem hiding this comment.
mostly for debugging + wanted to confirm my assumption that receiving duplicate proposals and voted blocks is uncommon, which it is
this client bin is more of an ideating space for the frontend part, not essential to the core functionality
Camillebzd
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.