Skip to content

Conversation

@Meshiest
Copy link
Contributor

@Meshiest Meshiest commented Oct 25, 2025

a series of changes required for building and running on snarkos v4.3

@Meshiest Meshiest changed the title chore: update utils for snarkos v4 chore: update utils for snarkos v4.3 Oct 25, 2025
@Meshiest Meshiest requested review from Copilot and gluax October 25, 2025 01:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the codebase to be compatible with snarkOS v4.3, transitioning from the deprecated cost-v1 boolean flag to a more flexible height-based consensus version determination system. The changes primarily involve updating API signatures, removing deprecated helper macros, and adjusting transaction cost estimation methods.

Key changes:

  • Replaced boolean cost_v1 flags with Option<u32> height parameters for consensus version determination
  • Updated snarkOS and snarkVM dependency revisions
  • Removed usage of deprecated cow_to_cloned! and cow_to_copied! macros
  • Updated API method signatures to accommodate snarkVM v4.3 changes

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated no comments.

Show a summary per file
File Description
scripts/dep_utils.sh Updated sed pattern to match new Cargo.toml structure for snarkvm dependencies
crates/controlplane/src/server/actions/execute.rs Changed from boolean cost flag to height-based consensus version determination
crates/controlplane/src/server/actions/deploy.rs Changed from boolean cost flag to height-based consensus version determination
crates/common/src/aot_cmds/mod.rs Replaced cost_v1 boolean with height parameter across command methods
crates/checkpoint/src/ledger.rs Removed deprecated cow_to_* macro usage and updated API calls
crates/checkpoint/src/aleo.rs Removed imports for deprecated cow_to_cloned and cow_to_copied macros
crates/aot/src/runner/mod.rs Added None parameters to function calls for new API signatures
crates/aot/src/runner/metrics.rs Updated metric names and array size for new snarkOS metrics
crates/aot/src/program/cost.rs Replaced cost_v1 flag with height-based consensus version lookup
crates/aot/src/ledger/util.rs Changed prepare method call to take reference instead of owned value
crates/aot/src/genesis.rs Removed deprecated additional_accounts_record_balance feature and simplified genesis record generation
crates/aot/src/cli.rs Changed default verbosity level and adjusted log filtering logic
crates/aot/src/auth/mod.rs Updated authorization commands to use height-based consensus version
crates/aot/src/auth/execute.rs Refactored query handling to use new QueryTrait interface
crates/aot/src/auth/auth_program.rs Replaced cost_v1 with height parameter for consensus version determination
crates/aot/src/auth/auth_id.rs Updated transaction tree construction API calls
crates/aot/src/auth/auth_fee.rs Refactored cost estimation to support v1, v2, and v3 consensus versions
README.md Updated documentation to reflect new height-based cost estimation
Cargo.toml Updated snarkOS/snarkVM dependencies and axum feature configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Meshiest Meshiest force-pushed the refactor-canary-4.3.3 branch from 5b87573 to 873019d Compare October 27, 2025 02:20
@Meshiest Meshiest force-pushed the refactor-canary-4.3.3 branch from 873019d to 9afb24d Compare October 27, 2025 02:33
@Meshiest Meshiest merged commit 9f64c34 into main Oct 27, 2025
7 of 8 checks passed
@Meshiest Meshiest deleted the refactor-canary-4.3.3 branch October 27, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants