Skip to content

fix: add missing @vibe/style dependency to @vibe/base#3331

Merged
rivka-ungar merged 1 commit intovibe4from
fix/add-missing-style-dependency-base
Mar 12, 2026
Merged

fix: add missing @vibe/style dependency to @vibe/base#3331
rivka-ungar merged 1 commit intovibe4from
fix/add-missing-style-dependency-base

Conversation

@rivka-ungar
Copy link
Copy Markdown
Contributor

Summary

  • Adds @vibe/style as a dependency to @vibe/base, which imports from @vibe/style/dist/mixins in its SCSS but didn't declare the dependency
  • Follow-up to fix: add missing @vibe/style dependency to component packages #3330 which fixed the same issue for 5 other component packages but missed @vibe/base
  • Without this, clean builds (after deleting dist/ and node_modules/) fail because Lerna doesn't know to build @vibe/style first

Test plan

  • Verified clean build passes: deleted all dist/ and node_modules/, ran yarn && yarn build successfully

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rivka-ungar rivka-ungar requested a review from a team as a code owner March 12, 2026 12:12
@qodo-free-for-open-source-projects
Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Add missing @vibe/style dependency to @vibe/base

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Adds missing @vibe/style dependency to @vibe/base package
• Fixes clean build failures when dist/ and node_modules/ are deleted
• Resolves Lerna build order issue for SCSS mixin imports
Diagram
flowchart LR
  A["@vibe/base package.json"] -- "adds dependency" --> B["@vibe/style ^4.0.0-alpha.1"]
  C["SCSS imports from @vibe/style/dist/mixins"] -- "now properly declared" --> B
  D["Clean build process"] -- "now succeeds" --> A
Loading

Grey Divider

File Changes

1. packages/base/package.json 🐞 Bug fix +1/-0

Add @vibe/style dependency declaration

• Adds @vibe/style as a dependency with version ^4.0.0-alpha.1
• Placed in the dependencies section alongside existing @vibe/shared dependency
• Ensures Lerna knows to build @vibe/style before @vibe/base during clean builds

packages/base/package.json


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects
Copy link
Copy Markdown
Contributor

qodo-free-for-open-source-projects bot commented Mar 12, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@rivka-ungar rivka-ungar merged commit 3bc2c6b into vibe4 Mar 12, 2026
11 of 12 checks passed
@rivka-ungar rivka-ungar deleted the fix/add-missing-style-dependency-base branch March 12, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants