fix: add missing @vibe/style dependency to @vibe/base#3331
Merged
rivka-ungar merged 1 commit intovibe4from Mar 12, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Review Summary by QodoAdd missing @vibe/style dependency to @vibe/base
WalkthroughsDescription• Adds missing @vibe/style dependency to @vibe/base package • Fixes clean build failures when dist/ and node_modules/ are deleted • Resolves Lerna build order issue for SCSS mixin imports Diagramflowchart LR
A["@vibe/base package.json"] -- "adds dependency" --> B["@vibe/style ^4.0.0-alpha.1"]
C["SCSS imports from @vibe/style/dist/mixins"] -- "now properly declared" --> B
D["Clean build process"] -- "now succeeds" --> A
File Changes1. packages/base/package.json
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
talkor
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@vibe/styleas a dependency to@vibe/base, which imports from@vibe/style/dist/mixinsin its SCSS but didn't declare the dependency@vibe/basedist/andnode_modules/) fail because Lerna doesn't know to build@vibe/stylefirstTest plan
dist/andnode_modules/, ranyarn && yarn buildsuccessfully🤖 Generated with Claude Code