-
Notifications
You must be signed in to change notification settings - Fork 359
docs: add v4 release banner and changelog entry #3337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+121
−0
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
packages/docs/src/pages/welcome/banner/Vibe4Banner.module.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| .vibe4Banner { | ||
| padding: var(--space-16); | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| margin: var(--space-8); | ||
| border-radius: var(--border-radius-medium); | ||
| position: relative; | ||
| overflow: hidden; | ||
|
|
||
| .content { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: var(--space-8); | ||
| z-index: 1; | ||
|
|
||
| .text { | ||
| color: #323338; | ||
| font-family: Poppins; | ||
| font-size: 16px; | ||
| font-style: normal; | ||
| font-weight: 400; | ||
| line-height: 100%; | ||
| letter-spacing: -0.12px; | ||
| display: flex; | ||
| align-items: center; | ||
| align-self: center; | ||
| gap: var(--space-4); | ||
| } | ||
|
|
||
| .title { | ||
| color: #323338; | ||
| font-family: Poppins; | ||
| font-size: 16px; | ||
| font-style: normal; | ||
| font-weight: 600; | ||
| line-height: 100%; | ||
| letter-spacing: -0.12px; | ||
| } | ||
|
|
||
| .link { | ||
| color: #323338; | ||
| text-decoration: underline; | ||
| font-size: 16px; | ||
| font-weight: 400; | ||
|
|
||
| &:hover { | ||
| opacity: 0.7; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .bubble1 { | ||
| width: 307.5px; | ||
| height: 232.5px; | ||
| position: absolute; | ||
| right: 518.5px; | ||
| bottom: -184.5px; | ||
| border-radius: 307.5px; | ||
| opacity: 0.4; | ||
| background: #d4b8ff; | ||
| filter: blur(120px); | ||
| } | ||
|
|
||
| .bubble2 { | ||
| width: 307.5px; | ||
| height: 232.5px; | ||
| position: absolute; | ||
| left: 358px; | ||
| top: -194px; | ||
| border-radius: 307.5px; | ||
| opacity: 0.4; | ||
| background: #90d0ff; | ||
| filter: blur(120px); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import React from "react"; | ||
| import styles from "./Vibe4Banner.module.scss"; | ||
|
|
||
| const Vibe4Banner: React.FC = () => { | ||
| return ( | ||
| <div className={styles.vibe4Banner}> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 1. vibe4banner missing data-vibe The Vibe4Banner root element is missing the required [data-vibe] attribute, reducing consistency for test automation and DOM identification. This violates the component root-attribute requirement. Agent Prompt
|
||
| <div className={styles.bubble1}></div> | ||
| <div className={styles.bubble2}></div> | ||
| <div className={styles.content}> | ||
| <div className={styles.text}> | ||
| <span className={styles.title}>Vibe 4 is here!</span> Check out the{" "} | ||
| <a | ||
| href="https://vibe.monday.com/?path=/docs/migration-guide--docs" | ||
| target="_blank" | ||
| rel="noreferrer" | ||
| className={styles.link} | ||
| > | ||
| migration guide | ||
| </a> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default Vibe4Banner; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2. Welcome detection may fail
🐞 Bug✓ CorrectnessVibe4Banner rendering depends on isWelcomePage checking window.location.href.includes("id=welcome"), which won’t match the repo’s common /?path=/docs/... routing; the banner can silently never render on the Welcome docs page. This breaks the PR’s intended behavior (banner shown on Welcome only) for path-based navigation.Agent Prompt
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools