Skip to content

fix(ColorPicker): add screen reader support for color announcements #3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rivka-ungar wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix(ColorPicker): add screen reader support for color announcements #3346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0b59015
fix(ColorPicker): add screen reader support for color announcements
rivka-ungar Apr 9, 2026
4146787
fix(ColorPicker): use index-based IDs to avoid invalid DOM IDs from s…
rivka-ungar Apr 9, 2026
4baef77
fix(ColorPicker): keep onClick/onMouseDown on Clickable, minimize beh…
rivka-ungar Apr 9, 2026
a9d3248
fix(ColorPicker): add role=presentation to Clickable to remove "group…
rivka-ungar Apr 9, 2026
fe40661
fix(ColorPicker): update interaction tests to use formatted color names
rivka-ungar Apr 9, 2026
649fdac
[prerelease]
rivka-ungar Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions packages/core/src/components/ColorPicker/__tests__/ColorPicker.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import ColorPicker from "../ColorPicker";
import { contentColors } from "../../../utils/colors-vars-map";
import ColorPickerColorsGrid from "../components/ColorPickerContent/ColorPickerColorsGrid";

const formatColorName = (color: string) => color.replace(/-|_/g, " ").replace(/(?:^|\s)\S/g, a => a.toUpperCase());

it("renders correctly with empty props", () => {
const tree = renderer.create(<ColorPicker />).toJSON();
expect(tree).toMatchSnapshot();
Expand All @@ -29,7 +31,7 @@ describe("ColorPicker", () => {
/>
);

const colorElementToClick = getByLabelText(colorToClick);
const colorElementToClick = getByLabelText(formatColorName(colorToClick));

act(() => {
fireEvent.click(colorElementToClick);
Expand All @@ -54,7 +56,7 @@ describe("ColorPicker", () => {
/>
);

const colorElementToClick = getByLabelText(colorToClick);
const colorElementToClick = getByLabelText(formatColorName(colorToClick));

act(() => {
fireEvent.click(colorElementToClick);
Expand All @@ -70,8 +72,8 @@ describe("ColorPicker", () => {

const { getByLabelText, queryByLabelText } = render(<ColorPicker isBlackListMode colorsList={blackListColors} />);

blackListColors.forEach(color => expect(queryByLabelText(color)).toBeNull());
const restOfColorsElements = restOfColors.map(color => getByLabelText(color));
blackListColors.forEach(color => expect(queryByLabelText(formatColorName(color))).toBeNull());
const restOfColorsElements = restOfColors.map(color => getByLabelText(formatColorName(color)));

expect(restOfColorsElements.length).toBe(restOfColors.length);
});
Expand All @@ -83,8 +85,8 @@ describe("ColorPicker", () => {
<ColorPicker isBlackListMode={false} colorsList={whiteListColors} />
);

const whiteListColorsElements = whiteListColors.map(color => getByLabelText(color));
restOfColors.forEach(color => expect(queryByLabelText(color)).toBeNull());
const whiteListColorsElements = whiteListColors.map(color => getByLabelText(formatColorName(color)));
restOfColors.forEach(color => expect(queryByLabelText(formatColorName(color))).toBeNull());

expect(whiteListColorsElements.length).toBe(whiteListColors.length);
});
Expand All @@ -111,10 +113,9 @@ describe("ColorPicker", () => {

it("should render tooltip with color name if showColorNameTooltip is true", () => {
const colorPicker = render(<ColorPicker showColorNameTooltip />);
const colorName = "done-green";
const colorNameTooltip = "Done Green";

const component = colorPicker.getByLabelText(colorName);
const component = colorPicker.getByLabelText(colorNameTooltip);
act(() => {
fireEvent.mouseOver(component);
});
Expand All @@ -129,7 +130,7 @@ describe("ColorPicker", () => {
const colorList = [colorName];
const colorPicker = render(<ColorPicker colorsList={colorList} showColorNameTooltip forceUseRawColorList />);

const component = colorPicker.getByLabelText(colorName);
const component = colorPicker.getByLabelText(colorNameTooltip);
act(() => {
fireEvent.mouseOver(component);
});
Expand All @@ -153,7 +154,8 @@ describe("ColorPicker", () => {
/>
);

const component = colorPicker.getByLabelText(colorName);
// When tooltipContentByColor has a custom label, aria-label uses that custom value
const component = colorPicker.getByLabelText(contentByColorTooltip);
act(() => {
fireEvent.mouseOver(component);
});
Expand Down
Loading
Loading