🐛 preserve active jobs when cleaning up completed scan jobs#1377
Merged
chris-rock merged 3 commits intomainfrom Feb 5, 2026
Merged
🐛 preserve active jobs when cleaning up completed scan jobs#1377chris-rock merged 3 commits intomainfrom
chris-rock merged 3 commits intomainfrom
Conversation
chris-rock
changed the title
Previously the controller would delete all jobs when updating CronJob specs, including active/running jobs. This could interrupt in-progress scans. The new DeleteCompletedJobs function only deletes jobs that have completed (succeeded or failed), preserving any active jobs. Includes tests for the new behavior.
chris-rock
force-pushed
the
fix/preserve-active-jobs
branch
from
dd30f24 to
a094bc1
Compare
- Handle NotFound errors on delete (race condition with TTL controller) - Change log level to V(1) to reduce noise during normal operation - Remove unused expectedDeleted field from tests - Add test for jobs with non-matching labels being preserved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeleteCompletedJobsfunction that only deletes completed/failed jobsContext
Previously the controller would delete all jobs when updating CronJob specs, including active/running jobs. This could interrupt long-running scans unexpectedly.
Test plan
DeleteCompletedJobsfunctionExtracted from #1337 - Original author: @jpaodev