Skip to content

Comments

slightly shortened human readable date time#4520

Open
HannesGitH wants to merge 1 commit intomonero-project:masterfrom
HannesGitH:master
Open

slightly shortened human readable date time#4520
HannesGitH wants to merge 1 commit intomonero-project:masterfrom
HannesGitH:master

Conversation

@HannesGitH
Copy link

e.g.

  • 1 day(s) ago -> 1 day ago
  • 2 day(s) ago -> 2 days ago

Copy link
Collaborator

@selsta selsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this take into account that delta is a float?

@HannesGitH
Copy link
Author

honestly, I had no idea how plurals would work here (never used qt), but now I dug into it and I think its now fixed the 'correct way'

@selsta
Copy link
Collaborator

selsta commented Feb 24, 2026

The .ts are machine generated and should not be touched manually, the code change needs to be in the .qml itself. I don't think we got plurals working correctly in other places.

@HannesGitH
Copy link
Author

I don't think we got plurals working correctly in other places

At least you got the same setup I put in the english file already in ther german one, so I suppose it might already be working, didnt check yet tho.

The .ts are machine generated and should not be touched manually,

then this changes shall probably be made in weblate.. Guess you are right w that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants