epee: include math header for upcoming Boost 1.89#10036
Merged
tobtoht merged 1 commit intomonero-project:masterfrom Aug 21, 2025
Merged
epee: include math header for upcoming Boost 1.89#10036tobtoht merged 1 commit intomonero-project:masterfrom
tobtoht merged 1 commit intomonero-project:masterfrom
Conversation
When building on Ubuntu 22.04 with GCC 11.4.0 and Boost 1.89.0.beta1,
the build failed with:
```
error: ‘floor’ was not declared in this scope
41 | num_char = (int)floor((float)num_char / (float)radix);
| ^~~~~
```
Signed-off-by: Michael Cho <michael@michaelcho.dev>
41 tasks
jeffro256
approved these changes
Aug 14, 2025
tobtoht
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building on Ubuntu 22.04 with GCC 11.4.0 and Boost 1.89.0.beta1, the build failed with:
monero/contrib/epee/src/abstract_http_client.cpp
Line 41 in 389e3ba
Seen while beta testing upcoming Boost 1.89.0 (planned release tomorrow, Aug 13) at Homebrew - Homebrew/homebrew-core#233031
No issues with Boost 1.88.0 so some Boost changes must have resulted in no longer indirectly including
math.horcmath.