adapt raw_query tests for QuerySet.raw_aggregate() #12
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
timgraham
force-pushed
the
mongodb-5.0.x
branch
2 times, most recently
from
d03cf96 to
ff43b2b
Compare
tests/raw_query/tests.py
Outdated
| query = [{"$match": {"last_name": "%(last)s" % {"last": "foo"}}}] | ||
| qset = Author.objects.raw_mql(query) | ||
| self.assertEqual( | ||
| repr(qset), | ||
| "<RawQuerySet: SELECT * FROM raw_query_author WHERE last_name = foo>", | ||
| "<MongoRawQuerySet: [{'$match': {'last_name': 'foo'}}]>", | ||
| ) | ||
| self.assertEqual( | ||
| repr(qset.query), | ||
| "<RawQuery: SELECT * FROM raw_query_author WHERE last_name = foo>", | ||
| "<MongoRawQuery: [{'$match': {'last_name': 'foo'}}]>", | ||
| ) | ||
|
|
||
| query = "SELECT * FROM raw_query_author WHERE last_name = %s" | ||
| qset = Author.objects.raw(query, {"foo"}) | ||
| query = [{"$match": {"last_name": "%s" % "foo"}}] | ||
| qset = Author.objects.raw_mql(query) | ||
| self.assertEqual( | ||
| repr(qset), | ||
| "<RawQuerySet: SELECT * FROM raw_query_author WHERE last_name = foo>", | ||
| "<MongoRawQuerySet: [{'$match': {'last_name': 'foo'}}]>", | ||
| ) | ||
| self.assertEqual( | ||
| repr(qset.query), | ||
| "<RawQuery: SELECT * FROM raw_query_author WHERE last_name = foo>", | ||
| "<MongoRawQuery: [{'$match': {'last_name': 'foo'}}]>", |
There was a problem hiding this comment.
I think these tests can be skipped since we ultimately don't support the params field
There was a problem hiding this comment.
We do need one test for __repr__() but we don't need to test this redundantly or with a query that uses string interpolation. Let's continue to edit this file here (so we can see the diff against the raw_query tests, but with the ultimate goal of putting this test app in the django-mongodb tests directory rather than merging these changes. So, for example, for tests that aren't applicable, remove them in the PR instead of adding skips.
There was a problem hiding this comment.
E.g. raw_query_ ?
Looks like we're going to move to |
timgraham
changed the title
Co-authored-by: Tim Graham <[email protected]>
timgraham
changed the title
|
These tests are incorporated in django-mongodb's |
feature: mongodb/django-mongodb-backend#183
These tests are incorporated in django-mongodb's
tests/raw_query_/test_raw_aggregate.pyand this PR shows the diff of how they were adapted.