Add sizeOfDocument #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
sizeOfDocumentfunction, that computes the size in bytes of a BSON document without having to serialise it to binary format.I wrote it for
mongodbproject, where MongoDB bulk insertion needs to estimate the size of the documents to be inserted before serialising them (trying to remain under the MongoDB maximum query limit).I also tried to add a QuickCheck test, but I'm not sure it's working as expected... I tried to tweak the QuickCheck options to avoid huge arbitrary generated documents, but I'm not sure that's the right approach.