feat!: bump default build tools to vs2022 for Windows MONGOSH-1648 #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmruiz
force-pushed
the
feature/upgrade-to-vs2022
branch
from
cb74758 to
12ccb2d
Compare
gribnoysup
approved these changes
Dec 4, 2023
addaleax
changed the title
This was referenced Oct 30, 2024
addaleax
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to nodejs/node#49051 the Node.js team dropped support for vs2019, so we need to upgrade BoxedNode to use vs2022 as the default toolchain.
Compiling with vs2019 will still be possible by providing the extra argument.vs2019.