chore: CHARTS-10161 Update react-scripts to v5 #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: Update chart examples to use parcel v2 package * chore: Ignore new parcel cache directory * chore: Update dashboard examples to use parcel v2 package * chore: Update chart examples to use parcel v2.13.3 package * chore: Update dashboard examples to use parcel v2.13.3 package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the dependabot alert in https://github.com/mongodb-js/charts-embed-sdk/security/dependabot/708 there was a high severity bug in the
webpack-dev-middlewarepackage that we were using. The only package that uses this is thereact-scriptspackage. To update the underlying package, I followed these changelogs:When updating 3 -> 4:
There seemed to be an update to
css-loadercausing the images not inside the/srcdirectory to not be resolved. As per facebook/create-react-app#9870 I put the images inside the/srcdirectory inside a new/imagesdirectory.When updating 4-> 5:
Webpack was updated to v5 which meant a bunch of polyfills were no longer supplied by default. Since we are using
react-scripts, we cannot directly update the webpack config. A workaround for this is to alias the npm packages to the corresponding browserify packages.Test Steps
npm installnpm start